-
Notifications
You must be signed in to change notification settings - Fork 317
Label text #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enhanced
Are you sure you want to change the base?
Label text #696
Conversation
limon-light
commented
Aug 27, 2025
|
Awesome work |
thanks <3 |
|
Goated but can you make it customizable? |
I mean, what more do you want on it? |
I mean like you can change the text in an input box ? |
yes you can just need to find the hash which is quite simple |
63bdbd3 to
b1d68ef
Compare
|
rebased. |
|
I don't see why we need this feature. |
In theory we can use this to tell people to inject at the main menu when they get a Battleye error. |
|
Yes |
| IMAGE_NT_HEADERS* GetNtHeader() const; | ||
|
|
||
| private: | ||
| template<typename R = void*, Symbol T> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert the changes to this file.
| { | ||
| AddLabelImpl(0x1B2EA75B, "YimMenu Story"); // Title Story Mode | ||
| AddLabelImpl(0xABB00DEB, "YimMenu"); // Title Pause Menu | ||
| AddLabelImpl(Joaat("PM_ENTER_MP"), "Play GTA Online with YimMenu"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use _J instead of Joaat. Also, I suggest you to remove all of these and add overrides for only these labels for now:
"HUD_BE_RESTART_EF_DISABLED_WITH_BE": "GTA Online requires BattlEye to be disabled. Please restart Grand Theft Auto V to disable BattlEye.",
"HUD_BE_RESTART_EF_ENABLED_NO_BE": "BattlEye is required to play GTA Online. Please restart Grand Theft Auto V to enable BattlEye.",
"HUD_BE_RESTART_SERVICE_NOT_RUNNING": "BattlEye is required to play GTA Online. Please restart Grand Theft Auto V to enable BattlEye.",| { | ||
| return Joaat(str); | ||
| } | ||
| static uint64_t ComputeHash(uint64_t value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these two.
| void InitImpl(); | ||
|
|
||
| template<typename T> | ||
| const char* GetTextImpl(const T& label) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only accept uint32_t.
| { | ||
| extern bool AssistedAimShouldReleaseEntity(__int64 a1); | ||
| extern const char* GetLabelText(void* unk, const char* label); | ||
| extern const char* GetLabelTextInternal(void* this_, uint32_t label_hash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need GetLabelText as it just calls the other one anyway. Remove it and rename GetLabelTextInternal to GetLabelText.